Enh/transmit unencoded #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 14, 2021 14:38
Needed for creation of bootstrap-tokens for machines introduced here: gardener/gardener#3902
gardener-robot
added
area/security
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
gardener-robot
added
merge/squash
10 tasks
This was referenced Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepts the flag
Transmit Unencoded.Needed for creation of bootstrap-tokens for machines introduced here: gardener/gardener#3902
Also revendors g/g to include fix for osc.status.
How to categorize this PR?
/area security
/kind enhancement
/os suse-chost
What this PR does / why we need it:
See gardener/gardener#3898 and gardener/gardener#3902
Special notes for your reviewer:
With
OS_CONFIG_FORMATunset the token generation worked as expected.I was not able to successfully test this with the env variable
OS_CONFIG_FORMATset tocloud-init. When I set this vms get created but the machine always stays inpendingstate. I tested it on AWS. The behaviour withmasteris the same for me so this PR does not make this worse. I would welcome if someone can double check ifcloud-initis also not working for them.Also dropping support for
cloud-initall together seems to be a viable option cc @vpnachevRelease note: