Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for multiple .networks.cloudNAT.natIPNames #266

Merged
merged 1 commit into from
May 14, 2021

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented May 13, 2021

/kind bug
/platform gcp

Before this PR, the rendered outputs for multiple natIPNames was:

output "nat_ips" {
  value = data.google_compute_address.manualnat4.address,data.google_compute_address.manualnat5.address
}

which results in the error described in #265.

With this PR, it is:

output "nat_ips" {
  value = "${data.google_compute_address.manualnat4.address},${data.google_compute_address.manualnat5.address}"
}

And the corresponding outputs in the terraform.tfstate:

        "nat_ips": {
          "value": "104.199.15.99,35.205.9.207",
          "type": "string"
        },

Fixes #265

Release note:

An issue causing Infrastructure with multiple `.networks.cloudNAT.natIPNames` to fail to be reconciled is now fixed.

@ialidzhikov ialidzhikov requested review from a team as code owners May 13, 2021 20:50
@gardener-robot gardener-robot added kind/bug Bug platform/gcp Google cloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 13, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 13, 2021
@ialidzhikov
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented May 13, 2021

Testrun: e2e-dp7t8
Workflow: e2e-dp7t8-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 9m7s     |
+---------------------+---------------------+-----------+----------+

Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 14, 2021
@timebertt timebertt merged commit 34ef58d into gardener:master May 14, 2021
timebertt added a commit that referenced this pull request May 14, 2021
…6-origin-release-v1.16

[release-v1.16] Automated cherry pick of #266: Fix support for multiple .networks.cloudNAT.natIPNames
@ialidzhikov ialidzhikov deleted the fix/nat-ip-names branch May 31, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid terraform config when more than 1 .networks.cloudNAT.natIPNames are specified
5 participants