Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace terraformer's helm chart with go templates #268

Merged
merged 1 commit into from
May 19, 2021
Merged

Replace terraformer's helm chart with go templates #268

merged 1 commit into from
May 19, 2021

Conversation

kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind cleanup
/platform gcp

What this PR does / why we need it:
Replace infrastructure helm chart with native go templates

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Replace infrastructure's terraform helm chart with native go templates.

@gardener-robot gardener-robot added area/control-plane Control plane related kind/cleanup Something that is not needed anymore and can be cleaned up platform/gcp Google cloud platform/infrastructure needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 19, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 19, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 19, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 19, 2021
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented May 19, 2021 •
edited
Loading

Testrun: e2e-rfmqv
Workflow: e2e-rfmqv-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 8m48s    |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 19, 2021
@kon-angelo kon-angelo marked this pull request as ready for review May 19, 2021 08:36
@kon-angelo kon-angelo requested review from a team as code owners May 19, 2021 08:36
@prashanth26
Copy link

prashanth26 commented May 19, 2021 •
edited
Loading

Hi @kon-angelo ,

Thanks for these changes. I somehow thought this change was done, and missed it :(
/assign

rfranzke
rfranzke approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels May 19, 2021
@rfranzke rfranzke requested a review from prashanth26 May 19, 2021 10:42
@prashanth26 prashanth26 merged commit 41a47b4 into gardener:master May 19, 2021
prashanth26
prashanth26 reviewed May 19, 2021
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo deleted the infra-templates branch May 19, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 left review comments

@rfranzke rfranzke rfranzke approved these changes

Assignees

@prashanth26 prashanth26

Labels
area/control-plane Control plane related kind/cleanup Something that is not needed anymore and can be cleaned up kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kon-angelo @prashanth26 @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot