Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated RBAC to allow node/status update by MCM #138

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Updated RBAC to allow node/status update by MCM #138

merged 1 commit into from
Sep 9, 2020

Conversation

prashanth26
Copy link

How to categorize this PR?

/area robustness
/kind enhancement
/priority normal
/platform openstack

What this PR does / why we need it:
There is a new change in MCM that lets MCM update node/status on the termination of machines. Refer - gardener/machine-controller-manager#492, this change will be a part of the upcoming MCM release (planned this week). This requires the following RBAC to be present for MCM on Gardener.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@prashanth26 prashanth26 requested review from a team as code owners September 9, 2020 04:57
@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure priority/normal labels Sep 9, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 9, 2020
@prashanth26
Copy link
Author

/invite @hardikdr @guydaichs

@gardener-robot gardener-robot added the needs/review Needs review label Sep 9, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 9, 2020
hardikdr
hardikdr approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 9, 2020
rfranzke
rfranzke approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit 7850021 into gardener:master Sep 9, 2020
@prashanth26 prashanth26 deleted the update/mcm-rbac branch October 4, 2020 08:57
@gardener-robot gardener-robot added the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@hardikdr hardikdr hardikdr approved these changes

@guydc guydc Awaiting requested review from guydc

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prashanth26 @hardikdr @rfranzke @gardener-robot-ci-2 @gardener-robot