Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly configure metrics-server #171

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area monitoring
/kind enhancement
/platform vsphere

What this PR does / why we need it:
Typically, the metrics-server tries to use the Hostname of Nodes in order to communicate with the kubelet and query metrics. However, pods running on vSphere cannot resolve the hostname of the VM, hence, the metrics-server fails and never becomes ready.

Similar to gardener/gardener-extension-provider-equinix-metal#162

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `metrics-server` is now properly able to communicate with the kubelets in order to expose metrics about nodes and pods.

@MartinWeindel MartinWeindel requested review from a team as code owners September 9, 2021 15:07
@gardener-robot gardener-robot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension platform/vsphere VMware vSphere platform/infrastructure needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Sep 9, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 9, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 9, 2021
@MartinWeindel MartinWeindel merged commit fbdb0a9 into master Sep 10, 2021
@MartinWeindel MartinWeindel deleted the shoot-webhook-metrics-server branch September 10, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/vsphere VMware vSphere platform/infrastructure size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants