Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable annotation controller on shoot #55

Merged
merged 1 commit into from
May 26, 2021
Merged

enable annotation controller on shoot #55

merged 1 commit into from
May 26, 2021

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
If Service or Ingress source resources cannot be annotated, because the object is overwritten periodically by an external component, it is possible to provide these annotations with a separate DNSAnnotation resource for the referenced object.
This feature of the dns-controller-manager is enabled with this PR.

Which issue(s) this PR fixes:
Fixes #48

Special notes for your reviewer:

Release note:

enable annotation controller to support `DNSAnnotation` resources

@MartinWeindel MartinWeindel requested review from a team as code owners May 20, 2021 11:41
@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 20, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 20, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 20, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 20, 2021
rfranzke
rfranzke reviewed May 21, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 21, 2021
timuthy
timuthy approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 26, 2021
@MartinWeindel MartinWeindel merged commit a486871 into master May 26, 2021
@MartinWeindel MartinWeindel deleted the dnsannotation branch May 26, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timuthy timuthy timuthy approved these changes

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activating DNSAnnotation controller
7 participants
@MartinWeindel @rfranzke @timuthy @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot