avoid conflicting updates of the status.state of the extension resource by the replication controller
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
area/control-plane
MartinWeindel
force-pushed
the
fix-update-conflict-on-extension
branch
from
5152297
to
d06e583
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
timuthy
requested changes
May 28, 2021
MartinWeindel
force-pushed
the
fix-update-conflict-on-extension
branch
from
d06e583
to
466ec7a
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
unit test for stringslock has been added |
MartinWeindel
force-pushed
the
fix-update-conflict-on-extension
branch
from
466ec7a
to
cfc97a8
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
fix-update-conflict-on-extension
branch
from
cfc97a8
to
8354233
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
fix-update-conflict-on-extension
branch
from
8354233
to
26dd5ce
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
@MartinWeindel You have pull request review with status CHANGES_REQUESTED, please check |
MartinWeindel
force-pushed
the
fix-update-conflict-on-extension
branch
from
26dd5ce
to
f82760a
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
mandelsoft
requested changes
Jun 1, 2021
MartinWeindel
force-pushed
the
fix-update-conflict-on-extension
branch
from
f82760a
to
b99b4b4
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
…llel Co-authored-by: Uwe Krueger <[email protected]>
MartinWeindel
force-pushed
the
fix-update-conflict-on-extension
branch
from
b99b4b4
to
2771aee
Compare
mandelsoft
approved these changes
Jun 1, 2021
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in parallel
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
The shoot-dns-service can loose its leader election if there is a high workload because of conflicting updates on replicating changed DNS entries into the DNS state of the extension object.
The replication controller, responsible for replication the entries into the
status.stateof the extension resource, now locks the namespace to avoid conflicting updates. If the namespace is already locked, the reconciliation is delay for about 1-2s.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: