Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Token Projection artefacts #35

Merged
merged 1 commit into from
May 21, 2022
Merged

Cleanup Token Projection artefacts #35

merged 1 commit into from
May 21, 2022

Conversation

rfranzke
Copy link
Member

What this PR does / why we need it:
This PR cleans up the conditions and constraints introduced in #31 related to the token projection story.

Release note:

The `kupid` extension for Gardener is only compatible with Gardener versions `>= v1.37`.

@rfranzke rfranzke requested a review from a team as a code owner April 28, 2022 13:39
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 28, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 28, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 28, 2022
@timebertt
Copy link
Member

/invite @kris94

timebertt
timebertt approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 3, 2022
@rfranzke
Copy link
Member Author

rfranzke commented May 3, 2022

/invite @ashwani2k

@gardener-robot gardener-robot added needs/review Needs review and removed reviewed/lgtm Has approval for merging labels May 3, 2022
@gardener-robot
Copy link

@ashwani2k, @kris94 You have pull request review open invite, please check

ashwani2k
ashwani2k approved these changes May 21, 2022
View reviewed changes
Copy link
Contributor

@ashwani2k ashwani2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Looks good to me.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 21, 2022
@ashwani2k ashwani2k merged commit 3675d7d into gardener:master May 21, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 21, 2022
@rfranzke rfranzke deleted the enh/cleanup branch May 21, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwani2k ashwani2k ashwani2k approved these changes

@timebertt timebertt timebertt approved these changes

@krgostev krgostev Awaiting requested review from krgostev

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rfranzke @timebertt @gardener-robot @ashwani2k @gardener-robot-ci-1 @gardener-robot-ci-3