Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the underlying client of the Sorting one #107

Merged

Conversation

vlvasilev
Copy link
Collaborator

How to categorize this PR?

/kind bug
/area logging
/priority normal

What this PR does / why we need it:
With this PR we close properly the underlying client of the Sorted client.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The Sorted client does not leak promtail Loki clients anymore.

@gardener-robot
Copy link

@vlvasilev Label priority/normal does not exist.

@gardener-robot gardener-robot added area/logging Logging related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 10, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 10, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 10, 2021
@vlvasilev vlvasilev merged commit 5f65505 into gardener:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Logging related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants