Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multitenant client bug #113

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

vlvasilev
Copy link
Collaborator

How to categorize this PR?

/kind bug
/area logging
/priority critical

What this PR does / why we need it:
This PR fixes the bug where the multitenant wrapper client removes the __gardener_multitenant_id__ label from a label set which is used for other log entries of the same types afterward.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix bug in gardener fluent-bit-to-loki plugin where `__gardener_multitenant_id__` is removed from a shared label set.

@gardener-robot gardener-robot added area/logging Logging related kind/bug Bug priority/critical Needs to be resolved soon, because it impacts users negatively needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Oct 6, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 6, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 6, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 6, 2021
@vlvasilev vlvasilev merged commit fc34e5c into gardener:master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Logging related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review priority/critical Needs to be resolved soon, because it impacts users negatively size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants