Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for fluent-bit v3 hot reload #231

Merged
merged 15 commits into from
Jun 22, 2024
Merged

Conversation

nickytd
Copy link
Collaborator

@nickytd nickytd commented Jun 22, 2024

/kind enhancement
/area logging

This PR adapts the plugin lifecycle to the fluent-bit v3 hot reload mechanism. Now the fluent-bit and the gardener-vali plugin support configuraiton reloads withput container restarts.

The logging plugin now supports fluent-bit v3 hot reload mechanism.

- cleans up the imports
- adds logs messages

to_squash

to_squash

chore(controller): refactor code to improve readability
- adds debug log messages
- unifies the messages
- update log messages

chore(plugin): add debug logs for client creation in plugins

to_squash in plugin
- removes the registered callbacks
- reformat code
- tune logs messages and severity
- use uuid as a plugin id
- use FLBPluginExitCtx to close plugins for hot reload
- remove singletons
- thread safe plugins slice update
- move informer initialization to package init
@gardener-robot gardener-robot added area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 22, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 22, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 22, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 22, 2024
@nickytd nickytd merged commit e896a49 into master Jun 22, 2024
14 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 22, 2024
@nickytd nickytd deleted the fluent-bit-v3-hot-reload branch June 22, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Logging related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants