-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding etcdctl and k9s install on demand script to make usage easier #102
Conversation
Why don't we just install the latest version instead of asking the user? |
I just took two current scripts - |
I think we should just install the latest version, if the user runs |
btw. I have also created #104 for k9s as we have an install script for this as well but does not yet support to install it on demand |
Arguments are passed directly to the binaries after they are installed, so I am not sure if that's a good idea. IMO having the option to specify version can come in handy and first invocation of those commands will anyway break whatever script (because of the y/n part) so I don't see a reason to currently remove versions. It would make sense if we decide to change it so when an operator invokes, for example, |
What about the following:
|
I made the on-demand binaries get installed when executed without any questions asked. |
do you want to change it to |
8c216e9
to
e709cbf
Compare
After a sync with @petersutter:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more minor suggestions. Rest looks very good, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Introduce `etcdctl` and `k9s` on demand scripts. Automatically generate `etcdctl` connectivity parameters when `wrapper` runs.
d64182d
to
04ffe84
Compare
What this PR does / why we need it:
This PR should make a bit easier for persons who troubleshoot to install
etcdctl
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I mostly copied/adapted things based on the existing install script and the same script for wireguard.
To check if the modification works as expected I did a local build of the image and tried installing and using
etdctl
.Release note: