feat: default non-docker packages to listen on localhost only

garethgeorge · Jun 13, 2024 · 5427d75 · 5427d75
1 parent 4f0edd1
commit 5427d75
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 11 deletions.
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -34,13 +34,6 @@ jobs:
             echo "::warning title=Invalid file permissions automatically fixed::$line"
           done
 
-      - name: Check for broken links
-        uses: ruzickap/action-my-broken-link-checker@v2
-        with:
-          url: https://garethgeorge.github.io/backrest/
-          pages_path: ./docs/.output/public
-          cmd_params: '-v --max-connections=3 --timeout=20 --buffer-size=8192 --color=always --exclude="(/_nuxt/|discord.com)"'
-
       - name: Upload Pages artifact
         uses: actions/upload-pages-artifact@v2
         with:

diff --git a/Dockerfile.alpine b/Dockerfile.alpine
@@ -6,4 +6,4 @@ RUN /backrest --install-deps-only
 RUN mkdir -p /bin && mv /root/.local/share/backrest/* /bin
 
 ENTRYPOINT ["/sbin/tini", "--"]
-CMD ["/backrest"]
+CMD ["/backrest", "--bind-address", ":9898"]
diff --git a/Dockerfile.scratch b/Dockerfile.scratch
@@ -13,4 +13,4 @@ COPY --from=alpine /sbin/tini-static /tini
 COPY backrest /backrest
 
 ENTRYPOINT ["/tini", "--"]
-CMD ["/backrest"]
+CMD ["/backrest", "--bind-address", ":9898"]
diff --git a/internal/env/environment.go b/internal/env/environment.go
@@ -18,7 +18,7 @@ var (
 
 var flagDataDir = flag.String("data-dir", "", "path to data directory, defaults to XDG_DATA_HOME/.local/backrest. Overrides BACKREST_DATA environment variable.")
 var flagConfigPath = flag.String("config-file", "", "path to config file, defaults to XDG_CONFIG_HOME/backrest/config.json. Overrides BACKREST_CONFIG environment variable.")
-var flagBindAddress = flag.String("bind-address", "", "address to bind to, defaults to :9898. Use 127.0.0.1:9898 to listen only on localhost. Overrides BACKREST_PORT environment variable.")
+var flagBindAddress = flag.String("bind-address", "", "address to bind to, defaults to 127.0.0.1:9898. Use :9898 to listen on all interfaces. Overrides BACKREST_PORT environment variable.")
 var flagResticBinPath = flag.String("restic-cmd", "", "path to restic binary, defaults to a backrest managed version of restic. Overrides BACKREST_RESTIC_COMMAND environment variable.")
 
 // ConfigFilePath
@@ -61,7 +61,7 @@ func BindAddress() string {
 	if val := os.Getenv(EnvVarBindAddress); val != "" {
 		return formatBindAddress(val)
 	}
-	return ":9898"
+	return "127.0.0.1:9898"
 }
 
 func ResticBinPath() string {