Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable googlebot and tests #869

Merged
merged 14 commits into from Sep 21, 2021
Merged

Disable googlebot and tests #869

merged 14 commits into from Sep 21, 2021

Conversation

riccardogiorato
Copy link
Contributor

Description of Change(s): make it possible to disable googlebot tags

dangerouslyDisableGoogleBot

Sometimes it might be possible that googlebot tags need to be removed from the source code of all pages on a website, to fix this usecase I added a single param called:

  • dangerouslyDisableGoogleBot, this will be set in the DefaultSeo component disabiling it on all pages

This will fix also this issue where people wanted to add this toggle: #367

disableGooglebot

I also added a simple "disableGooglebot" param to NextSeo to be used in all the cases where someone wants to remove googletags but it's not using DefaulySeo and dangerouslyDisableGoogleBot!


Some things to help get a PR reviewed and merged faster:

  • Have you updated the documentation to go with your changes? yes
  • Have you written or updated unit tests? yes
  • Have you written an integration test in the test app supplied? yes

As an extra things I also added some E2E test to check for the other dangerously set fields like noindex and nofollow!

@riccardogiorato
Copy link
Contributor Author

riccardogiorato commented Sep 21, 2021

Hey @garmeeh the problem with all the github actions that are stuck is due to the fact that github is not hosting ubuntu-16.04 anymore and all the builds remain stuck!

I also fixed this here: https://github.com/garmeeh/next-seo/pull/869/files#diff-1db27d93186e46d3b441ece35801b244db8ee144ff1405ca27a163bfe878957fR5

Now the CI build works again!
When you merge this PR would you be open to other PR?

I would love to became a contributor of this great package!
I have seen a few other things I could improve like making the CI process even faster than the current 3 minutes required!

@garmeeh
Copy link
Owner

garmeeh commented Sep 21, 2021

Oh wow thanks for spotting that @riccardogiorato!

I would definitely be open to more PR's! 😄

I am actually just about to rewrite the library to make it a bit easier to maintain. Once I get a draft PR up with a bit of direction on it any help would be more than welcome.

Two main goals are making:

  • JSON-LD's extendable and share common code
  • Completely re-factor test app and tests to make them more readable and easier to maintain. I think there may be a few things that are not tested also

@garmeeh garmeeh merged commit 3330385 into garmeeh:master Sep 21, 2021
@riccardogiorato riccardogiorato deleted the disable-googlebot-and-tests branch September 23, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants