-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Button for Selecting All ComboBox Entries #63
Comments
Hi @jstueckrath, Thanks for the proposal and for the detailed description. Regarding the special button inside the component, it's an interesting idea. Though I am thinking if it would be confusing to users, unless it's a familiar pattern to them. It would be nice to think a bit more about the design and the behavior before trying to do any further implementation. |
@gatanaso, I am also not sure what the best design would be and if there even is a best design. The behaviour I described above worked well in my case, but is far from perfect. The logic is done on server-side limiting offline capability and the "select all" entry is layouted the same as all other entries, although it behaves differently. I have very little experience in UX design, so I am not sure which design would be the best. Is there even a standard icon for "select all"? Nevertheless, a good design could improve the combo box. |
hi @jstueckrath @gatanaso an alternative would be similar to the approach you took @jstueckrath, with a new list item at the top or bottom of the list. with a few pointers from @gatanaso i'm available to do some work on this feature. i personally like the first option with a discreet icon button to do the magic and we are not adding a 'fake' list item to work as a button. as an interim workaround i can float an icon button beside the combobox and do the select-all behaviour server side but that's not great for the user. Thanks for building an incredible component. |
@timmer3 I was wondering whether it makes sense to display the new icon together with the clear icon if at least one but not all items are selected. It would be helpful since this allows to select or deselect all items at once at anytime without opening the box. However, the space taken is probably not justified (especially in compact mode) given that you can do this by two clicks (first clear and then select all). Moreover, I also vote for a property to toggle this feature. |
…tanaso#63) - add a new select-all button next to the clear and toggle button - use a font-icon specific for both Lumo and Material themes - update demo page to include a demo of the select-all button - update tests
This feature would be really nice, so I tried to implement it. The result is proposed via the pull-request #100. Please, take a look and let me know your opinions. I think it looks good from the UX perspective. |
- use a data provider for obtaining items if provided - update tests
In my project I needed the possibility to select all entries of the combo box and wrote a wrapper for it. However, I think this would be a good improvement for the box itself. In my case the last entry in the combo box had the label "select all" and did the following:
Although this is a possible way, I think one could achieve a better result by adding a button similar to the existing clear indicator. Maybe this can be extended functionally and visually to do the task as well?
The text was updated successfully, but these errors were encountered: