Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix colors in Github dark-mode. #168

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Fix colors in Github dark-mode. #168

merged 2 commits into from
Feb 9, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

Fixes #165

Uses variables from Github CSS to stay aligned with Github color scheme. Drawback - if Github drops the variables the extension will fall back to default browser colors.

Dropdown:
Screenshot 2021-02-09 at 21 39 56
Screenshot 2021-02-09 at 21 40 29

Modal:
github com_spring-cloud_spring-cloud-aws_issues_356
github com_spring-cloud_spring-cloud-aws_issues_356 (1)

johnmurphy01
johnmurphy01 requested changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@johnmurphy01 johnmurphy01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change, otherwise looks great. I like the use of CSS variables, a much more elegant solution than what I had originally. If Github decides to change or remove those variables, we can adjust accordingly

css/style.css Outdated Show resolved Hide resolved
johnmurphy01
johnmurphy01 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@johnmurphy01 johnmurphy01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for yet another PR

@johnmurphy01 johnmurphy01 merged commit 2fa25c7 into gatewayapps:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmurphy01 johnmurphy01 johnmurphy01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support new GitHub dark mode
2 participants
@maciejwalkowiak @johnmurphy01