fix(register-service-worker): show an error if installing SW not over…

… HTTPS (#8958) * Error if attempting to use SWs over HTTP * Use console.error * Only register the SW if there's no error
gatsbyjs · Oct 9, 2018 · 2ba57ea · 2ba57ea
1 parent 9d4cd78
commit 2ba57ea
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/gatsby/cache-dir/load-directly-or-404.js b/packages/gatsby/cache-dir/load-directly-or-404.js
@@ -4,7 +4,7 @@ export function getRedirectUrl(path) {
   // This should never happen, but check just in case - otherwise, there would
   // be an infinite redirect loop
   if (url.search.match(/\?(.*&)?no-cache=1(&|$)/)) {
-    console.log(
+    console.error(
       `Found no-cache=1 while attempting to load a page directly; ` +
         `this is likely due to a bug in Gatsby, or a misconfiguration in your project.`
     )

diff --git a/packages/gatsby/cache-dir/register-service-worker.js b/packages/gatsby/cache-dir/register-service-worker.js
@@ -1,6 +1,13 @@
 import { apiRunner } from "./api-runner-browser"
 
-if (`serviceWorker` in navigator) {
+if (
+  window.location.protocol !== `https:` &&
+  window.location.hostname !== `localhost`
+) {
+  console.error(
+    `Service workers can only be used over HTTPS, or on localhost for development`
+  )
+} else if (`serviceWorker` in navigator) {
   navigator.serviceWorker
     .register(`${__PATH_PREFIX__}/sw.js`)
     .then(function(reg) {