stop builds on errors in built-html step (#6188)

* use new babel-code-frame API * stop build after errors in build-html stage and display nicely formatted error message
gatsbyjs · Jun 28, 2018 · 386db39 · 386db39
1 parent 58571be
commit 386db39
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/gatsby-cli/src/reporter/prepare-stack-trace.js b/packages/gatsby-cli/src/reporter/prepare-stack-trace.js
@@ -3,7 +3,7 @@
  */
 
 const { readFileSync } = require(`fs`)
-const babelCodeFrame = require(`@babel/code-frame`)
+const { codeFrameColumns } = require(`@babel/code-frame`)
 const stackTrace = require(`stack-trace`)
 const { SourceMapConsumer } = require(`source-map`)
 
@@ -28,10 +28,14 @@ function getErrorSource(map, topFrame) {
   let source = map.sourceContentFor(topFrame.getFileName(), true)
   return (
     source &&
-    babelCodeFrame(
+    codeFrameColumns(
       source,
-      topFrame.getLineNumber(),
-      topFrame.getColumnNumber(),
+      {
+        start: {
+          line: topFrame.getLineNumber(),
+          column: topFrame.getColumnNumber(),
+        },
+      },
       {
         highlightCode: true,
       }

diff --git a/packages/gatsby/src/commands/build-html.js b/packages/gatsby/src/commands/build-html.js
@@ -53,7 +53,7 @@ module.exports = async (program: any) => {
           return resolve(null, stats)
         })
         .catch(e => {
-          console.log(e)
+          reject(createErrorFromString(e.stack, `${outputFile}.map`))
         })
     })
   })