-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install react and react-dom globally? When installing the cli. #18603
Comments
I ran into the same issue, also resolved with installing globally |
We are also seeing this issue - rolling back to 2.7.58 seems to have fixed the issue. Without these installed globally none of the CLI commands work and you see an error saying react-dom is missing. |
Also seeing this issue and had to downgrade |
Having exact same error as well. |
Opening PR with fix soon. Thanks for report! |
Can you try installing |
This seems like a bug in react-redux. We should also file an issue there (in addition to unblocking ourselves). |
Yeah - |
worked for me.. |
Same issue lie for me while installing react and react dom global it is resolved npm install -g react |
Works 😄 |
We are getting some failing tests on PR with fix (which is what I used for |
Published in |
Yeah, the reasoning for this is:
So, since the standard use case is that folks will have ReactDOM or React Native loaded already, we don't actually specify a dependency or peer dependency on either. It sounds like there may be some new kind of "optional peer dependencies" metadata that NPM and Yarn are starting to support, so we might end up declaring those. |
Thanks for your response here! I lacked context around decision to not include either |
When I clean install the cli I get this weird prompts on the absence of react and react-dom.
When I add them globally it works. Are they set as peer dependencies?
Is this normal? Or am I missing something...
The text was updated successfully, but these errors were encountered: