Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-cli): work around react-redux hidden dependency on react-dom #18607

Merged
merged 3 commits into from
Oct 14, 2019
Merged

fix(gatsby-cli): work around react-redux hidden dependency on react-dom #18607

merged 3 commits into from
Oct 14, 2019

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Oct 14, 2019 •
edited
Loading

This is super weird - react-redux his hidden dependency on react-dom, and we didn't caught that because we weren't installing cli globally (it worked because react-dom was available in monorepo node_modules or in project directory)

fixes #18603

@pieh pieh requested a review from a team as a code owner October 14, 2019 10:07
@pieh pieh mentioned this pull request Oct 14, 2019
Closed
@m-allanson
Copy link
Contributor

Flaky test failure? I restarted it.

@pieh
Copy link
Contributor Author

pieh commented Oct 14, 2019

That failing test seems pretty consistent (it failed 3 times in a row on same test):
cypress-screenshot (3). I'll do more thorough check

sidharthachatterjee
sidharthachatterjee approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @pieh

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Oct 14, 2019
@gatsbybot gatsbybot merged commit 01a8354 into gatsbyjs:master Oct 14, 2019
@sidharthachatterjee
Copy link
Contributor

Published in [email protected]

@pieh pieh deleted the add-react-dom-to-cli-wat branch October 14, 2019 12:50
@vladar vladar mentioned this pull request Oct 17, 2019
Merged
@pieh pieh restored the add-react-dom-to-cli-wat branch May 17, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install react and react-dom globally? When installing the cli.
4 participants
@pieh @m-allanson @sidharthachatterjee @gatsbybot