Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: migrate gatsby-core-utils to TypeScript #22041

Closed
danielkov opened this issue Mar 7, 2020 · 6 comments
Closed

[chore]: migrate gatsby-core-utils to TypeScript #22041

danielkov opened this issue Mar 7, 2020 · 6 comments
Assignees
@danielkov

Comments

@danielkov
Copy link
Contributor

Description

This is a ticket to keep track of all the individual PRs for each file required to update this package to TypeScript.

Umbrella: #22040
@danielkov danielkov added the type: bug An issue or pull request relating to a bug in Gatsby label Mar 7, 2020
@danielkov danielkov self-assigned this Mar 7, 2020
@danielkov danielkov added status: assigned and removed type: bug An issue or pull request relating to a bug in Gatsby labels Mar 7, 2020
This was referenced Mar 7, 2020
Closed
Closed
@MichaelDeBoey
Copy link
Contributor

This is already tracked in #21995

This was referenced Mar 8, 2020
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Closed
@danielkov
Copy link
Contributor Author

@MichaelDeBoey I wanted to keep track of gatsby-core-utils related changes separately for convenience. Both tickets are mentioned in PRs. Is this something I shouldn't do?

@MichaelDeBoey
Copy link
Contributor

I don't see any benefits in tracking the same thing twice

@blainekasten
Copy link
Contributor

@danielkov No worries on the duplicate issue. It'll be closed soon after we merge all of your PR's :)

One request that I see consistent on all of your PRs is that we want to change our exports to be named exports and shy away from export default. Can you make that change in all your PRs?

@blainekasten
Copy link
Contributor

Also tests are failing. Let me know when you get that fixed up!

@blainekasten blainekasten reopened this Mar 8, 2020
@JustFly1984
Copy link

#22070

@blainekasten blainekasten mentioned this issue Mar 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielkov danielkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JustFly1984 @blainekasten @MichaelDeBoey @danielkov