chore(gatsby-core-utils): ci to TS #22047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2020
blainekasten
reviewed
Mar 8, 2020
| @@ -1,13 +1,13 @@ | |||
| const ciInfo = jest.genMockFromModule(`ci-info`) | |||
| const ciInfo: typeof import("ci-info") = jest.genMockFromModule(`ci-info`) | |||
There was a problem hiding this comment.
is this valid? typically import() are async. So this seems off. /shrug
There was a problem hiding this comment.
I think you're referring to Webpack's import() function that does async import. In TypeScript you can pull in the export signature this way.
Merged
blainekasten
added a commit
that referenced
this pull request
Mar 10, 2020
* chore(gatsby-core-utils): get-config-store to TS (#22051) * chore(gatsby-core-utils): get-config-store to TS * chore(gatsby-core-utils): change getConfigStore to named export * chore(gatsby-core-utils): ci to TS (#22047) * chore(gatsby-core-utils): package.json added type * chore(gatsby-core-utils): mocks convert ci-info to TS * chore(gatsby-core-utils): ci to TS * chore(gatsby-core-utils): add @types/ci-info * chore(gatsby-core-utils): re-install dependencies to fix order * chore(gatsby-core-utils): cpu-core-count to TS (#22048) * chore(gatsby-core-utils): create-content-digest to TS (#22049) * chore(gatsby-core-utils): tests create-content-digest to TS * chore(gatsby-core-utils): create-content-digest to TS * chore(gatsby-core-utils): create-require-from-path to TS (#22050) * chore(gatsby-core-utils): get-gatsby-version to TS (#22052) * chore(gatsby-core-utils): index to TS (#22053) * chore(gatsby-core-utils): index to TS * chore(gatby-core-utils): changed getConfigStore to named export in #22051 * chore(gatsby-core-utils): path to ts (#22054) * chore(gatsby-core-utils): tests path to TS * chore(gatsby-core-utils): path to ts * chore(gatsby-core-utils): url to TS (#22056) * chore(gatsby-core-utils): tests url to TS * chore(gatsby-core-utils): url to TS * migrate more files * fix the rest * better exports * fix lints * fix building * fix test Co-authored-by: Daniel Emod Kovacs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection ticket for these tasks: #22041
☂ ticket: #21995