Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any reason this is forced to be HTTP? #24130

Closed
zoubarevm opened this issue May 15, 2020 · 4 comments · Fixed by #24227
Closed

Any reason this is forced to be HTTP? #24130

zoubarevm opened this issue May 15, 2020 · 4 comments · Fixed by #24227
Assignees
Labels
help wanted Issue with a clear description that the community can help with. topic: source-contentful Related to Gatsby's integration with Contentful type: question or discussion Issue discussing or asking a question about Gatsby

Comments

@zoubarevm
Copy link
Contributor

const url = `http://${node.file.url.slice(2)}`

@gatsbot gatsbot bot added type: question or discussion Issue discussing or asking a question about Gatsby status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 15, 2020
@DanielRuf
Copy link
Contributor

This was probably overseen in reviews.

#10682

@TylerBarnes TylerBarnes added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 15, 2020
@vladar
Copy link
Contributor

vladar commented May 19, 2020

@axe312ger Should this be https instead? Sorry if I am tagging you inappropriately but I was told you will keep an eye on contentful source plugin.

@zoubarevm
Copy link
Contributor Author

@vladar and @axe312ger - I've changed it to https and it all works locally. Our environment doesn't permit http connections and caused this error. I'm not entirely sure if there's a value in doing this is a flag or whether to just default it to https as that is the preferred method of communication with contentful by default.

@vladar
Copy link
Contributor

vladar commented May 19, 2020

It makes perfect sense to me to have https there. But I am not sure if we should still support http as an option (I doubt so but I am not an expert here). Anyways, a PR is welcome for this simple change!

@vladar vladar added the help wanted Issue with a clear description that the community can help with. label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with. topic: source-contentful Related to Gatsby's integration with Contentful type: question or discussion Issue discussing or asking a question about Gatsby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants