Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-source-contentful): Use https instead of http when downloading assets #24227

Merged
merged 1 commit into from
May 20, 2020
Merged

fix(gatsby-source-contentful): Use https instead of http when downloading assets #24227

merged 1 commit into from
May 20, 2020

Conversation

zoubarevm
Copy link
Contributor

Description

Update the source url to use https instead of http.

Documentation

As per https://www.contentful.com/developers/docs/references/http-details/ , https is the recommended approach.

Related Issues

Fixes #24130

@zoubarevm zoubarevm requested a review from a team as a code owner May 19, 2020 16:10
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 19, 2020
vladar
vladar approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR!

@vladar vladar added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 20, 2020
@vladar vladar changed the title use https instead of http fix(gatsby-source-contentful): Use https instead of http when downloading assets May 20, 2020
@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label May 20, 2020
@gatsbybot gatsbybot merged commit b49f74b into gatsbyjs:master May 20, 2020
@gatsbot
Copy link

gatsbot bot commented May 20, 2020

Holy buckets, @zoubarevm — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Any reason this is forced to be HTTP?
3 participants
@zoubarevm @vladar @gatsbybot