Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createRedirect broke gatsby-plugin-netlify redirects on 2.32.7 #29779

Closed
jaska120 opened this issue Feb 25, 2021 · 11 comments · Fixed by #30155
Closed

createRedirect broke gatsby-plugin-netlify redirects on 2.32.7 #29779

jaska120 opened this issue Feb 25, 2021 · 11 comments · Fixed by #30155
Assignees
Labels
type: bug An issue or pull request relating to a bug in Gatsby

Comments

@jaska120
Copy link

jaska120 commented Feb 25, 2021

Hi,

newly merged PR and published as version 2.32.7 broke gatsby-plugin-netlify redirects implementation. The release (#29742) introduced a new prop ignoreCase which is passed to the build output of _redirects file on gatsby-plugin-netlify

I am not sure which way is right: introducing a new prop which with default value of false instead of undefined or the way gatsby-plugin-netlify including all the props to the output.

The result now:

  • _redirects file outputs ignoreCase=false by default, which in turn is not recognized on Netlify and therefore the redirects are not working.
@jaska120 jaska120 added the type: bug An issue or pull request relating to a bug in Gatsby label Feb 25, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 25, 2021
@LekoArts LekoArts added topic: netlify and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 26, 2021
@sidharthachatterjee sidharthachatterjee self-assigned this Feb 26, 2021
@sidharthachatterjee
Copy link
Contributor

I’ll push a fix to the netlify plugin to resolve this today. Thanks for reporting!

@mlenser
Copy link

mlenser commented Feb 26, 2021

We can confirm the same problem. Thanks for looking into it!

@ohsnapitscolin
Copy link

ohsnapitscolin commented Mar 4, 2021

Following up here, did this fix go out? We're running into the same issue and had to revert to restore our redirects functionality. Upgraded to the latest version of gatsby-plugin-netlify but still seeing the issue.

@oskareke
Copy link

oskareke commented Mar 8, 2021

This is causing a lot of trouble for us SEO-wise... any updates?

@Corroshop
Copy link

Following up here, did this fix go out? We're running into the same issue and had to revert to restore our redirects functionality. Upgraded to the latest version of gatsby-plugin-netlify but still seeing the issue.

@ohsnapitscolin What version did you revert back to when you restored your redirects functionality?

@jackhair
Copy link

jackhair commented Mar 10, 2021

Following up here, did this fix go out? We're running into the same issue and had to revert to restore our redirects functionality. Upgraded to the latest version of gatsby-plugin-netlify but still seeing the issue.

@ohsnapitscolin What version did you revert back to when you restored your redirects functionality?

Hi @Corroshop I'm on the same team as @ohsnapitscolin, our issue came when we upgraded from 2.32.0 to 2.32.8, so we reverted straight back to 2.32.0 once we found the issue was breaking a lot of our redirects.

@sidharthachatterjee
Copy link
Contributor

Apologies for the delay in fixing this. A fix is now open in #30155 and should be merged and released soon. Cheers!

@vladar
Copy link
Contributor

vladar commented Mar 15, 2021

Published in [email protected]

@fivetwelve
Copy link

Published in [email protected]

Any resolution for builds that are not using Gatsby 3.x? There may be a lot and my project is one of them.

After adding 3.0.1 of the plugin...
warn Plugin gatsby-plugin-netlify is not compatible with your gatsby version 2.32.9 - It requires gatsby@^3.0.0-next.0

@vladar
Copy link
Contributor

vladar commented Mar 18, 2021

@fivetwelve This is also backported and published in [email protected]

@fivetwelve
Copy link

Much appreciated @vladar 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment