Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-netlify): Add an allow list for redirect options #30155

Merged

Conversation

sidharthachatterjee
Copy link
Contributor

Fixes #29779

Currently we add all values to the redirects file for Netlify. This PR changes that behaviour to only do so for values that are known and documented in https://docs.netlify.com/routing/redirects/

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 10, 2021
@sidharthachatterjee sidharthachatterjee force-pushed the sid/ch26635/fix-issue-in-createredirect-that-broke-gatsby branch from abcd857 to a4d684a Compare March 10, 2021 11:32
@LekoArts LekoArts added topic: netlify and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 10, 2021
Copy link

@jaska120 jaska120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Country and Language props should be allowed too

Copy link

@jaska120 jaska120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing tests but let's get this in :)

@vladar
Copy link
Contributor

vladar commented Mar 15, 2021

Published in [email protected]

pieh pushed a commit that referenced this pull request Mar 18, 2021
…30155) (#30215)

(cherry picked from commit 962c4a1)

Co-authored-by: Sidhartha Chatterjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createRedirect broke gatsby-plugin-netlify redirects on 2.32.7
5 participants