-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-plugin-netlify): Add an allow list for redirect options #30155
fix(gatsby-plugin-netlify): Add an allow list for redirect options #30155
Conversation
abcd857
to
a4d684a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Country
and Language
props should be allowed too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing tests but let's get this in :)
…30155) (#30261) (cherry picked from commit 962c4a1) Co-authored-by: Sidhartha Chatterjee <[email protected]>
Published in |
…30155) (#30215) (cherry picked from commit 962c4a1) Co-authored-by: Sidhartha Chatterjee <[email protected]>
Fixes #29779
Currently we add all values to the redirects file for Netlify. This PR changes that behaviour to only do so for values that are known and documented in https://docs.netlify.com/routing/redirects/