Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gatsby-source-contentful] Image file extension in capital letters #30069

Closed
xmflsct opened this issue Mar 7, 2021 · 2 comments · Fixed by #30103
Closed

[gatsby-source-contentful] Image file extension in capital letters #30069

xmflsct opened this issue Mar 7, 2021 · 2 comments · Fixed by #30103
Assignees
@ascorbic
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics topic: source-contentful Related to Gatsby's integration with Contentful type: bug An issue or pull request relating to a bug in Gatsby

Comments

@xmflsct
Copy link

xmflsct commented Mar 7, 2021

Description

Upgraded to Gatsby 3.0.3 and Contentful plugin 5.0.1, also using the new gatsby-plugin-image.
I get the following warning:

Invalid image format "JPG". Supported types are jpg, png and webp"
The resolver for image //images.ctfassets.net/***/***/***/***.JPG returned an invalid value.

Steps to reproduce

See build log here https://github.com/xmflsct/terradelft-website/runs/2048384373

Expected result

Maybe auto tranform to lower cases?

Actual result

.JPG is not recognised as .jpg

Environment

Run gatsby info --clipboard in your project directory and paste the output here.
@xmflsct xmflsct added the type: bug An issue or pull request relating to a bug in Gatsby label Mar 7, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 7, 2021
@xmflsct
Copy link
Author

xmflsct commented Mar 7, 2021

gatsby/packages/gatsby-source-contentful/src/extend-node-type.js

Line 37 in 2f59995

const validImageFormats = new Set([`jpg`, `png`, `webp`])
This line is where the problem is. Reverting to use gatsby-image works fine as before.

xmflsct added a commit to xmflsct/terradelft-website that referenced this issue Mar 7, 2021
@xmflsct
Revert back to use gatsby-image for now for Contentful images
b5ee7e4 
gatsbyjs/gatsby#30069
@LekoArts LekoArts added topic: source-contentful Related to Gatsby's integration with Contentful topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 8, 2021
@ascorbic ascorbic mentioned this issue Mar 8, 2021
Merged
@ascorbic ascorbic self-assigned this Mar 8, 2021
@vladar
Copy link
Contributor

vladar commented Mar 9, 2021

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ascorbic ascorbic

Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics topic: source-contentful Related to Gatsby's integration with Contentful type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(gatsby-source-contentful): Set image source format gatsbyjs/gatsby
4 participants
@vladar @ascorbic @xmflsct @LekoArts