[1.0] Add more core modules to commons bundle + strip prop-types #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove prop-types
|
Deploy preview ready! Built with commit 72da219 |
jquense
reviewed
May 19, 2017
| @@ -155,6 +155,11 @@ module.exports = async function babelConfig(program, stage) { | |||
| babelrc.plugins.unshift(`react-hot-loader/babel`) | |||
| } | |||
|
|
|||
| if (stage !== `develop`) { | |||
| // Remove prop-types in production. | |||
| babelrc.plugins.unshift(`transform-react-remove-prop-types`) | |||
There was a problem hiding this comment.
Does this affect files parsed in source plugins? React-bootstrap uses/depends on some runtime propType logic and that would break the doc site i'm building with react-docgen :P
There was a problem hiding this comment.
oh! Ummm yes it would :-)
Hmmm ok I naively thought this would be a safe global optimization but clearly not. Thanks for heads up :-) I'll remove it.
|
Deploy preview ready! Built with commit 3db8b54 |
|
Deploy preview ready! Built with commit 72da219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.