Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Add internal plugin to map internal data to data system to make queryable #1014

Merged
merged 10 commits into from
May 22, 2017

Conversation

KyleAMathews
Copy link
Contributor

No description provided.

@gatsbybot
Copy link
Collaborator

gatsbybot commented May 22, 2017

Deploy preview ready!

Built with commit 6ffaa85

https://deploy-preview-1014--using-drupal.netlify.com

@KyleAMathews
Copy link
Contributor Author

KyleAMathews commented May 22, 2017

Deploy preview failed.

Built with commit 6ffaa85

https://app.netlify.com/sites/gatsbygram/deploys/5922f6203c1d5e7fd065077b

@KyleAMathews
Copy link
Contributor Author

KyleAMathews commented May 22, 2017

Deploy preview ready!

Built with commit 6ffaa85

https://deploy-preview-1014--gatsbyjs.netlify.com

@KyleAMathews
Copy link
Contributor Author

KyleAMathews commented May 22, 2017

@KyleAMathews
Copy link
Contributor Author

This PR took a bit of a detour. It turns out you're not supposed to use Redux's store.subscribe for listening for new actions as it's a "state update" emitter not an "action" emitter. Which is ideal for a UI-focused tool.

Anyways, we need to be able to listen to every events so I used EventEmitter2 to setup our own little event system.

@KyleAMathews KyleAMathews merged commit 007c8bb into 1.0 May 22, 2017
@KyleAMathews KyleAMathews deleted the internal-data branch May 22, 2017 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants