Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Graphql update to v14 #11568

Closed
wants to merge 7 commits into from
Closed

Conversation

sibiraj-s
Copy link
Contributor

Description

Recently Graphql is updated to v14. this should complete the update.

Note: I have updated the package documentation in gatsby-transformer-documentation as jest tests failed due to some issue is caused by one of its dependencies during post install. the package updated from v7 to v9 which is breaking.

Related Issues

Fixes #11507

@sibiraj-s sibiraj-s requested a review from a team as a code owner February 5, 2019 14:29
@saranshkataria
Copy link
Contributor

@sibiraj-s I messed up while resolving the conflicts and now cannot push to the branch to fix it, sorry about that!

@pieh
Copy link
Contributor

pieh commented Feb 6, 2019

Note: I have updated the package documentation in gatsby-transformer-documentation as jest tests failed due to some issue is caused by one of its dependencies during post install. the package updated from v7 to v9 which is breaking.

This is super weird - just for test I'll temporarily remove documentation change (and fixup current problem with yarn.lock ;P). Ideally we wouldn't update unrelated stuff here - I could bump documentation package as part of #11597

@pieh
Copy link
Contributor

pieh commented Feb 6, 2019

@saranshkataria when there are conflicts in yarn.lock file you can run yarn [bootstrap] and it will resolve conflicts automatically, you don't need to resolve them manually (and it's also super difficult to do in general) :)

@pieh
Copy link
Contributor

pieh commented Feb 7, 2019

@sibiraj-s it seems only failing test is caused by some regression introduced in #11581, so we should be good dropping unrelated documentation version bump (but I will do this in my PR)

@sibiraj-s
Copy link
Contributor Author

so we should be good dropping unrelated documentation version

Okay @pieh.

@stefanprobst
Copy link
Contributor

Looks like this is the same as #11512

@wardpeet
Copy link
Contributor

wardpeet commented Apr 8, 2019

Thanks so much for the PR!

Unfortunately, we're not going to merge this at this time. It seems like a duplicate of this one #11512 got reverted.

As such--we're going to close this out. We want you to know that we certainly want to keep you as a contributor to Gatsby, so we'd encourage you to check out our open issues.

Thanks again, and we look forward to seeing more PRs from you in the future! 💪 💜

@wardpeet wardpeet closed this Apr 8, 2019
@wardpeet wardpeet deleted the complete-graphql-update branch April 8, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants