Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not merge - just testing something #12763

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ aliases:
test_template: &test_template
steps:
- checkout
- run: node -v
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 hopefully the executors are working like we'd expect! Good idea.

- run: ./scripts/assert-changed-files.sh "packages/*|.circleci/*"
- <<: *restore_cache
- <<: *install_node_modules
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ function matchesSnapshot(query) {
expect(code).toMatchSnapshot()
}


it(`on node 8+`, () => {
expect(
parseInt(process.version.match(/(\d+)\./)[0].slice(0, -1)) >= 8
).toBeTruthy()
})

it.todo(
`Works correctly with the kitchen sink`
// , () => {
Expand Down