-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated es-lint docs to instruct how to install eslint-config-react-app #12998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for jumping on this!
…bout es lint config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth mentioning and linking the shipped ESLint file here too for reference. So that developers are aware that a more complex version exists internally: https://github.com/gatsbyjs/gatsby/blob/master/.eslintrc.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweaked the copy some to remove mentions of Prettier and to be more direct that Gatsby ships with .eslintrc and you add your own config file only if you want to modify that.
Thanks @lukebrobbs!
Holy buckets, @lukebrobbs — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
I know this issue has been closed for a while, and I can open a new one if need be, but I find the language confusing on https://www.gatsbyjs.org/docs/eslint/ In the main section it says:
but further down the page it says:
On first read-through, it appears to contradict the first statement and imply that by using the snippet on the page, you're losing out on all the things from the default config. |
Description
eslint-config-react-app
Related Issues
#12980