Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 3 blog posts about WordPress and Gatsby #13292

Merged
merged 9 commits into from
Apr 25, 2019
Merged

Added 3 blog posts about WordPress and Gatsby #13292

merged 9 commits into from
Apr 25, 2019

Conversation

iamtimsmith
Copy link
Contributor

Description

Added series of blog posts about using WordPress to build a blog with Gatsby per our conversation on twitter. Originally found at https://www.iamtimsmith.com/blog/

@iamtimsmith iamtimsmith requested a review from a team April 11, 2019 15:07
pieh
pieh reviewed Apr 11, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for cross-posting!

docs/blog/2019-04-03-how-to-build-a-blog-with-wordpress-and-gatsby-part-1/index.md Outdated Show resolved Hide resolved
docs/blog/2019-04-03-how-to-build-a-blog-with-wordpress-and-gatsby-part-1/index.md Outdated Show resolved Hide resolved
docs/blog/2019-04-03-how-to-build-a-blog-with-wordpress-and-gatsby-part-1/index.md Outdated Show resolved Hide resolved
docs/blog/2019-04-04-how-to-build-a-blog-with-wordpress-and-gatsby-part-2/index.md Outdated Show resolved Hide resolved
@iamtimsmith
Changed code images to text, added video demo of wp_trigger_netlify_b…
68096cd 
…uild, and clarified version of plugin needed.
@iamtimsmith
Copy link
Contributor Author

@pieh I have made the requested changes by changing the images of code over to actual code with syntax highlighting, adding a video of the WordPress netlify plugin working, and clarifying the version needed of the Menu API plugin.

DSchau
DSchau reviewed Apr 15, 2019
View reviewed changes
docs/blog/2019-04-04-how-to-build-a-blog-with-wordpress-and-gatsby-part-2/index.md Outdated

Below is the code I'm using for the template starter. This is just to make sure things are working after you finish setting up your `gatsby-node.js` logic. Once you know the page is being created, you will update the template to display correctly.

```javascript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```javascript
```javascript:title=src/templates/BlogPost.js

Also would be interesting if we add a directive, e.g. something like

/* title=src/templates/BlogPost.js */

as the first line of a code block. But--outside the scope of this PR!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DSchau Is that possible currently? I'd be happy to do that since I'm not thrilled about the commented file name look. If not, it would be an awesome addition!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not possible currently! Future work--if you're interested in making this change, it'd be adding some functionality to gatsby-remark-prismjs!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DSchau Sure, I'd be interested in looking into that. I assume that will be a separate issue though. Should I just work on it and create the issue with the PR when I have a solution?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely!

@iamtimsmith
Copy link
Contributor Author

I have made the requested changes (with the exception of the separate issue discussed). Is there anything else I need to do?

@iamtimsmith
Copy link
Contributor Author

@pieh @DSchau It's been a bit since this was updated. Should I change the dates for the posts to be current dates? Also is there anything else I need to do before this gets merged?

@marcysutton marcysutton added the status: awaiting author response Additional information has been requested from the author label Apr 24, 2019
@marcysutton marcysutton removed the status: awaiting author response Additional information has been requested from the author label Apr 25, 2019
marcysutton
marcysutton approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These posts are so great. Thanks for contributing, @iamtimsmith! 🙌

@iamtimsmith
Copy link
Contributor Author

@marcysutton Thanks! I'm a big supporter of Gatsby and was excited to meet the team at DrupalCon Seattle.

@marcysutton
Copy link
Contributor

@iamtimsmith nice, that was a good time!

BTW I've asked the Gatsby team about adjusting the dates of your posts, as I do think we should update them. When I hear more about a publishing schedule I can go ahead and make the changes!

@iamtimsmith
Copy link
Contributor Author

@marcysutton Awesome. Thanks!

@marcysutton
Copy link
Contributor

marcysutton commented Apr 25, 2019 •
edited
Loading

I've updated the dates for all three posts to go out on different days:

  • Friday (tomorrow) 4/26
  • Tuesday 4/30
  • Thursday 5/2

As soon as the checks are complete I will merge it!

@marcysutton marcysutton merged commit 84bcb9d into gatsbyjs:master Apr 25, 2019
@gatsbot
Copy link

gatsbot bot commented Apr 25, 2019

Holy buckets, @iamtimsmith — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSchau DSchau DSchau left review comments

@pieh pieh pieh left review comments

@marcysutton marcysutton marcysutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamtimsmith @marcysutton @pieh @DSchau @LekoArts