[gatsby-remark-images] allow user-specified max-width to overwrite presentationWidth #15952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sentationWidth This is useful when you e.g. want to use non-pixel units for max-width Fix #15578
pieh
reviewed
Jul 28, 2019
| rawHTML = ` | ||
| <span | ||
| class="${imageWrapperClass}" | ||
| style="position: relative; display: block; margin-left: auto; margin-right: auto; ${ | ||
| imageCaption ? `` : wrapperStyle | ||
| } max-width: ${presentationWidth}px;" | ||
| } ${shouldApplyMaxWidth ? `max-width: ${presentationWidth}px;` : ``}" |
There was a problem hiding this comment.
What about moving max-width before ${imageCaption ? : wrapperStyle}``? So maxWidth from user supplied `wrapperStyle` would overwrite default one.
This seems fragile - we have 2 different conditions relying on imageCaption and if we ever change this condition in future, it's very easy to miss it in one of the places
|
ping @birjolaxew any chance you can resolve this comment? |
|
@birjolaxew I hope this means change of focus and not any problems happening in your personal life! Even tho we didn't get to finish this changeset - I'd like to thank you for opening this PR ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently gatsby-remark-images enforces a
max-widthon each image equal to thepresentationWidthreturned by gatsby-plugin-sharp. Any user-specifiedmax-widthin thewrapperStyleis simply ignored.Use case for custom
max-widthis described in #15578This PR adds support for specifying a
max-widthin thewrapperStylewhich will be used instead of thepresentationWidth.Related Issues
Fixes #15578