Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(themes): move themes into starters and packages #16178

Closed
wants to merge 11 commits into from
Closed

chore(themes): move themes into starters and packages #16178

wants to merge 11 commits into from

Conversation

sidharthachatterjee
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee commented Jul 29, 2019 •
edited
Loading

Why

Theme packages should now be publishable (is that even a word) by lerna

What

This pull request

  • moves theme starters into the starters directory
  • moves theme packages into the package directory
  • updates fields in package.json accordingly
  • cleans up renovate config
  • cleans up lerna config
  • cleans up CI config
  • excludes theme starter README from markdown magic

@sidharthachatterjee sidharthachatterjee requested review from a team as code owners July 29, 2019 07:05
wardpeet
wardpeet previously approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Configs have been reset to the previous values so 👍. Not sure if any testing needs to be done.

@sidharthachatterjee
Copy link
Contributor Author

sidharthachatterjee commented Jul 29, 2019 •
edited by wardpeet
Loading

@wardpeet Shouldn’t need any testing per se but let’s wait on a go ahead from the themes team?

Cc @johno @ChristopherBiscardi @gatsbyjs/themes-core

@sidharthachatterjee
Copy link
Contributor Author

So turns out adding starters to the workspace breaks in all sorts of ridiculous ways 😂

https://app.circleci.com/jobs/github/gatsbyjs/gatsby/182460 fails with sh: 1: gatsby: not found because dependencies are hoisted to the root as a result of adding this to the workspace and scripts/validate-starters.sh deletes all of node_modules and then runs yarn which for some reason results in no gatsby in .bin

https://app.circleci.com/jobs/github/gatsbyjs/gatsby/182462 fails because of some snapshot mismatches where it expects "<PROJECT_ROOT>/packages/babel-preset-gatsby/node_modules/@babel/runtime" but gets "<PROJECT_ROOT>/node_modules/@babel/runtime" which I guess makes sense because of hoisting 🤔

Another snapshot test fails (it transforms HTML img tags). This one is strange.

@sidharthachatterjee sidharthachatterjee force-pushed the chore/move-themes-into-starters-and-packages branch 2 times, most recently from 7dfd4c9 to e9256bd Compare July 30, 2019 12:57
@sidharthachatterjee sidharthachatterjee force-pushed the chore/move-themes-into-starters-and-packages branch from e9256bd to 36386fe Compare July 30, 2019 12:59
johno added a commit to johno/gatsby that referenced this pull request Aug 1, 2019
@johno
chore(themes): Manually bump dependencies in theme starters
1f193ac 
Right now, until gatsbyjs#16178 starters aren't managed by lerna
so their dependencies haven't been updated. There have been
a handful of bugfixes that aren't being installed by default
until the user upgrades their dependencies.
@johno johno mentioned this pull request Aug 1, 2019
Merged
@sidharthachatterjee sidharthachatterjee added status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged and removed status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged labels Aug 21, 2019
@sidharthachatterjee
Copy link
Contributor Author

Closing this in favour of a new one because holy hell look at those conflicts

@ChristopherBiscardi
Copy link
Contributor

leaving a post-close comment that this approach is good with me and we'll work out whatever we need to with gatsby-dev later.

@vladar vladar mentioned this pull request Oct 18, 2019
Merged
@MichaelDeBoey MichaelDeBoey deleted the chore/move-themes-into-starters-and-packages branch January 20, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sidharthachatterjee @ChristopherBiscardi @wardpeet @lannonbr