Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add history as top-level dependency #174

Merged
merged 1 commit into from
Mar 7, 2016
Merged

Add history as top-level dependency #174

merged 1 commit into from
Mar 7, 2016

Conversation

scottnonnenberg
Copy link
Contributor

history is being half-installed by npm 2.14.12 due to scroll-behavior peerDependency, which caused the webpack build to fail when it couldn't find history's dependency 'warning.' This does not happen in npm 3.x because all dependencies are installed at top level.

This was the webpack error:

ERROR in /usr/local/lib/~/gatsby/~/history/lib/DOMStateStorage.js
Module not found: Error: Cannot resolve module 'warning' in /usr/local/lib/node_modules/gatsby/node_modules/history/lib
 @ /usr/local/lib/~/gatsby/~/history/lib/DOMStateStorage.js 10:15-33

Note that history was also installed under react-router, where it had all required dependencies.

Also removes this warning:

npm WARN peerDependencies The peer dependency history@^1.12.1 || ^2.0.0 included from scroll-behavior will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.

@scottnonnenberg
Add history as top-level dependency
abe7a80 
Half-pulled in by npm 2.14.12 due to scroll-behavior peerDependency,
which caused the webpack build to fail when it couldn't find history's
dependency 'warning.' This does not happen in npm 3.x because all 
dependencies are installed at top level.
@scottnonnenberg scottnonnenberg mentioned this pull request Mar 7, 2016
Merged
KyleAMathews added a commit that referenced this pull request Mar 7, 2016
@KyleAMathews
Merge pull request #174 from scottnonnenberg/fix-npm-2x
1e44024 
Add history as top-level dependency
@KyleAMathews KyleAMathews merged commit 1e44024 into gatsbyjs:master Mar 7, 2016
@KyleAMathews
Copy link
Contributor

Thanks!

@scottnonnenberg scottnonnenberg deleted the fix-npm-2x branch March 7, 2016 18:10
@KyleAMathews KyleAMathews mentioned this pull request Mar 10, 2016
Closed
mef added a commit to mef/gatsby-starter-blog that referenced this pull request Mar 24, 2016
@mef
Add history as top-level dependency
72b6c5f 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby/pull/174)
mef added a commit to mef/gatsby-starter-default that referenced this pull request Mar 24, 2016
@mef
Add history as top-level dependency
7446687 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby#174)
This was referenced Mar 24, 2016
Merged
Merged
mef added a commit to mef/gatsby-starter-documentation that referenced this pull request Mar 24, 2016
@mef
Add history as top-level dependency
1c62540 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby#174)
@mef mef mentioned this pull request Mar 24, 2016
Merged
mef added a commit to mef/gatsby-starter-default that referenced this pull request Mar 24, 2016
@mef
Add js-yaml as top-level dependency
e170888 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby#174)

Error message:

    ERROR in ./wrappers/yaml.js
    Module not found: Error: Cannot resolve module 'js-yaml' in /home/username/gatsby-default/wrappers
     @ ./wrappers/yaml.js 17:14-32

`gatsby develop` starts well after performing this change.
@mef mef mentioned this pull request Mar 24, 2016
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 22, 2020
Open
This was referenced Feb 1, 2020
Open
Open
idev-a pushed a commit to idev-a/landing-page-gatsby that referenced this pull request Dec 14, 2020
Add history as top-level dependency
2bf4d07 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby#174)
idev-a pushed a commit to idev-a/landing-page-gatsby that referenced this pull request Dec 14, 2020
Add js-yaml as top-level dependency
1a93ff8 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby#174)

Error message:

    ERROR in ./wrappers/yaml.js
    Module not found: Error: Cannot resolve module 'js-yaml' in /home/username/gatsby-default/wrappers
     @ ./wrappers/yaml.js 17:14-32

`gatsby develop` starts well after performing this change.
goldenjake pushed a commit to goldenjake/gatsby-starter-default that referenced this pull request May 19, 2022
@mef
Add history as top-level dependency
60f5768 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby#174)
goldenjake pushed a commit to goldenjake/gatsby-starter-default that referenced this pull request May 19, 2022
@mef
Add js-yaml as top-level dependency
f2f3232 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby#174)

Error message:

    ERROR in ./wrappers/yaml.js
    Module not found: Error: Cannot resolve module 'js-yaml' in /home/username/gatsby-default/wrappers
     @ ./wrappers/yaml.js 17:14-32

`gatsby develop` starts well after performing this change.
This was referenced Nov 9, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 30, 2022
Open
hardcarry1995 added a commit to hardcarry1995/gatsby-netlify-form-example-v2 that referenced this pull request Dec 28, 2022
@hardcarry1995
Add history as top-level dependency
0e7e9a9 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby#174)
hardcarry1995 added a commit to hardcarry1995/gatsby-netlify-form-example-v2 that referenced this pull request Dec 28, 2022
@hardcarry1995
Add js-yaml as top-level dependency
1ddb26e 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby#174)

Error message:

    ERROR in ./wrappers/yaml.js
    Module not found: Error: Cannot resolve module 'js-yaml' in /home/username/gatsby-default/wrappers
     @ ./wrappers/yaml.js 17:14-32

`gatsby develop` starts well after performing this change.
leonhiat added a commit to leonhiat/gatsby-starter-blog that referenced this pull request Oct 31, 2023
@leonhiat
Add history as top-level dependency
0d7d256 
was causing the webpack build to fail (cf similar problem fixed in gatsbyjs/gatsby/pull/174)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottnonnenberg @KyleAMathews