Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update "Images, Files & Video" & link titles in sidebar #18358

Merged

Conversation

andersonnguyen
Copy link
Contributor

Description

Updated sidebar titles and breadcrumb titles of items listed under the "Images, Files & Video" section of the docs to adhere to the Gatsby Style Guide.

Changes include:

  • Revising sidebar titles to use title case
  • Revising breadcrumb titles to use title case
  • Adding suggestions for breadcrumb titles where breadcrumb titles weren't already provided

Related Issues

Related to #18284

Update titles and breadcrumb titles of items listed under the "Images, Files & Video" section of doc-links.yaml
@andersonnguyen andersonnguyen requested a review from a team as a code owner October 9, 2019 01:47
@andersonnguyen andersonnguyen changed the title Update "Images, Files & Video" docs sidebar titles to adhere to style guide. Update "Images, Files & Video" doc links titles to adhere to style guide. Oct 9, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've added a few remarks to make the breadcrumb titles a bit nicer.

www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
@wardpeet wardpeet changed the title Update "Images, Files & Video" doc links titles to adhere to style guide. docs: Update "Images, Files & Video" & link titles in sidebar Oct 9, 2019
@wardpeet wardpeet added status: awaiting author response Additional information has been requested from the author type: documentation An issue or pull request for improving or updating Gatsby's documentation labels Oct 9, 2019
andersonnguyen and others added 3 commits October 9, 2019 19:16
'gatsby-image' is not descriptive enough as a breadcrumb title when considering the entire breadcrumb chain.

Co-Authored-By: Ward Peeters <[email protected]>
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me, thanks for doing the work @andersonnguyen!

@wardpeet wardpeet merged commit 5dd15b0 into gatsbyjs:master Oct 10, 2019
@gatsbot
Copy link

gatsbot bot commented Oct 10, 2019

Holy buckets, @andersonnguyen — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@marcysutton marcysutton added Hacktoberfest and removed status: awaiting author response Additional information has been requested from the author labels Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants