Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Update title casing #18375

Merged
merged 6 commits into from
Oct 14, 2019
Merged

fix(docs): Update title casing #18375

merged 6 commits into from
Oct 14, 2019

Conversation

ziel-ar
Copy link
Contributor

@ziel-ar ziel-ar commented Oct 9, 2019

Description

I updated all titles in 'docs' directory using Title Case.
There were cases where some titles had quotation marks, i removed them for unification.

Related Issues

Related to #18284

@ziel-ar ziel-ar requested a review from a team as a code owner October 9, 2019 11:37
marcysutton
marcysutton suggested changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is an awesome PR! Thanks for submitting it. I have one recommended change, but it's really close.

docs/docs/add-custom-webpack-config.md Outdated Show resolved Hide resolved
@wardpeet wardpeet changed the title Update Title Case fix(docs): Update title casing Oct 14, 2019
wardpeet
wardpeet previously approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Great work @ziel-ar, a lot of doc pages that needed fixing! 👏.

wardpeet
wardpeet previously approved these changes Oct 14, 2019
View reviewed changes
@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Oct 14, 2019
@ziel-ar ziel-ar requested a review from wardpeet October 14, 2019 10:21
@wardpeet wardpeet merged commit 31141f7 into gatsbyjs:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

@marcysutton marcysutton Awaiting requested review from marcysutton

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ziel-ar @marcysutton @wardpeet