-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): fix hashes used in webpack for output #18973
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dbe4dd5
fix(gatsby): use hashes as module identifiers for webpack caching
wardpeet 2ce5c4b
fix(gatsby): disable hmr on production builds for css
wardpeet dfb9ff3
update absolute path to relative ones
wardpeet d1c275d
Merge remote-tracking branch 'upstream/master' into fix/webpack-hash-…
cdc14dd
Merge remote-tracking branch 'upstream/master' into fix/webpack-hash-…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -469,6 +469,10 @@ module.exports = async ( | |
runtimeChunk: { | ||
name: `webpack-runtime`, | ||
}, | ||
// use hashes instead of ids for module identifiers | ||
// TODO update to deterministic in webpack 5 (hashed is deprecated) | ||
// @see https://webpack.js.org/guides/caching/#module-identifiers | ||
moduleIds: `hashed`, | ||
splitChunks: { | ||
name: false, | ||
chunks: `all`, | ||
|
@@ -497,6 +501,8 @@ module.exports = async ( | |
test: /\.(css|scss|sass|less|styl)$/, | ||
chunks: `all`, | ||
enforce: true, | ||
// this rule trumps all other rules because of the priority. | ||
priority: 10, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The z-index of webpack builds |
||
}, | ||
}, | ||
}, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it deprecated though? Is the recommendation to use something else (that is deterministic as well)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value is "deterministic" not "hashed". It's a new value in webpack 5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh alrighty