Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gatsby-plugin-sharp] Bump sharp to 0.18.2 #1920

Closed
wants to merge 2 commits into from

Conversation

jeffrey-xiao
Copy link
Contributor

Switched my operating system to solus and ./node_modules/.bin/gatsby build started to failed. I dug into it and it seems like solus support was added in [email protected]. See issue. I manually tested and gatsby-plugin-sharp installed properly after bumping sharp.

Operating system: Solus
Node: v8.4.0
Npm: v5.3.0

@gatsbybot
Copy link
Collaborator

gatsbybot commented Aug 26, 2017

Deploy preview ready!

Built with commit 7702337

https://deploy-preview-1920--gatsbygram.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit ce3eb2c

https://deploy-preview-1920--using-drupal.netlify.com

@KyleAMathews
Copy link
Contributor

I've been waiting on the improvements to the attention crop to get it since that's our default crop mode lovell/sharp#832 (comment)

@KyleAMathews
Copy link
Contributor

It looks like they've been added to libvips already. So we just need to wait for an update to sharp.

@KyleAMathews
Copy link
Contributor

Deploy preview failed.

Built with commit 7702337

https://app.netlify.com/sites/using-glamor/deploys/59dfd520df99531fda7ab38b

@KyleAMathews
Copy link
Contributor

Closing this until sharp updates.

@fk fk added API/Plugins status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged labels Jan 19, 2018
@fk
Copy link
Contributor

fk commented Jan 26, 2018

@jeffrey-xiao sharp v0.19 is here: #3675!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants