Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e-tests): add regression test for resolution conflicts of local plugins and themes #19476

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Nov 13, 2019

Description

This is a quick follow up for #19470. It adds a missing regression test. This test fails before the fix and works after it.

@vladar vladar requested a review from a team as a code owner November 13, 2019 13:38
@vladar vladar changed the title test(e2e-tests): tests against resolution conflicts of local plugins and themes test(e2e-tests): add regression test for resolution conflicts of local plugins and themes Nov 13, 2019
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sidharthachatterjee sidharthachatterjee merged commit 5fb1322 into master Nov 13, 2019
@sidharthachatterjee sidharthachatterjee deleted the vladar-19470-follow-up branch November 13, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants