Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blog): Add "Faster Sites with Optimized Media Assets" to blog. #20735

Merged
merged 12 commits into from
Mar 1, 2020
Merged

chore(blog): Add "Faster Sites with Optimized Media Assets" to blog. #20735

merged 12 commits into from
Mar 1, 2020

Conversation

Chuloo
Copy link
Contributor

@Chuloo Chuloo commented Jan 21, 2020

Blog post

This post had been approved before writing.

Added the article, bio, and an Avatar image.

@Chuloo Chuloo requested a review from a team as a code owner January 21, 2020 01:13
@hashimwarren hashimwarren self-requested a review January 21, 2020 15:34
@gatsbybot
Copy link
Collaborator 

docs/blog/author.yaml: SyntaxError: Document is not valid YAML (bad indentation?) (379:3)
   377 |   avatar: avatars/scott-byrne.jpg
   378 |   twitter: "@scottpbyrne"
 > 379 |   - id: William Imoh
       |   ^^^^^^^^^^^^^^^^^^
 > 380 |   bio: Developer Advocate and Product Manager at Mart Labs
       | ^^^
   381 |   avatar: avatars/william-imoh.jpg
   382 |   twitter: "@iChuloo"
   383 |

@Ekwuno Ekwuno changed the title article: Added article, avatar and bio chore(blog): Add "Faster Sites with Optimized Media Assets" to blog. Feb 24, 2020
Ekwuno
Ekwuno reviewed Feb 24, 2020
View reviewed changes
docs/blog/2020-01-12-faster-sites-with-optimized-media-assets/index.md Outdated

## gatsby-source-cloudinary Plugin

gatsby-source-cloudinary is a plugin that fetches media assets from Cloudinary. You must first specify the folder from which to query those assets. The plugin then transforms them into Cloudinary file nodes, which can be queried with GraphQL in a Gatsby project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding a hyperlink to point to https://www.npmjs.com/package/gatsby-source-cloudinary. This would give the option to read more about the installation process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try gatsbyjs.org/packages/gatsby-source-cloudinary/ instead of the NPM page

StefanNieuwenhuis
StefanNieuwenhuis previously approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@StefanNieuwenhuis StefanNieuwenhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are typo's, but just last names ;)

@Ekwuno
Copy link
Contributor

Ekwuno commented Feb 24, 2020

I don't think these are typo's, but just last names ;)

Yea! I agree. The typoCheck picks them out for some reason

@hashimwarren
Copy link
Contributor

Looks great! I made some of the changes Obinna suggested and changed the publish date

@hashimwarren hashimwarren added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 27, 2020
@Chuloo
Copy link
Contributor Author

Chuloo commented Mar 1, 2020

Thanks, @hashimwarren @StefanNieuwenhuis @Ekwuno 👍

@hashimwarren hashimwarren merged commit 399412a into gatsbyjs:master Mar 1, 2020
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Open
This was referenced Oct 6, 2020
Open
Open
@ajesse11x ajesse11x mentioned this pull request Feb 23, 2021
Open
@saurabharch saurabharch mentioned this pull request Feb 23, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 19, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 29, 2022
Open
This was referenced Jul 21, 2022
Open
Open
@ajesse11x ajesse11x mentioned this pull request Aug 24, 2022
Open
@saurabharch saurabharch mentioned this pull request Nov 27, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Apr 16, 2024
Open
@saurabharch saurabharch mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekwuno Ekwuno Ekwuno requested changes

@hashimwarren hashimwarren hashimwarren approved these changes

@StefanNieuwenhuis StefanNieuwenhuis StefanNieuwenhuis left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Chuloo @gatsbybot @Ekwuno @hashimwarren @StefanNieuwenhuis @lannonbr