Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Do not add field id to the query when id alias exists #20980

Merged
merged 2 commits into from
Jan 29, 2020
Merged

fix(gatsby): Do not add field id to the query when id alias exists #20980

merged 2 commits into from
Jan 29, 2020

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Jan 29, 2020 •
edited
Loading

Description

A follow up for #20849 That PR doesn't take into account aliases. So when alias for id exists, we shouldn't auto-add id field to the query

Related Issues

#20943

@vladar vladar requested a review from a team as a code owner January 29, 2020 08:30
@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jan 29, 2020
@gatsbybot gatsbybot merged commit acf2c35 into master Jan 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the vladar/github-20943 branch January 29, 2020 10:12
@vladar
Copy link
Contributor Author

vladar commented Jan 29, 2020

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freiksenet freiksenet freiksenet approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladar @freiksenet @gatsbybot