Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Guide on working with Etsy in Gatsby #21580

Merged
merged 22 commits into from
Mar 10, 2020
Merged

[docs]: Guide on working with Etsy in Gatsby #21580

merged 22 commits into from
Mar 10, 2020

Conversation

bball07
Copy link
Contributor

@bball07 bball07 commented Feb 19, 2020

Description

Reference Guide on working with Etsy in Gatsby.

Related Issues

New guide on working with Etsy #20226

@bball07 bball07 requested review from a team as code owners February 19, 2020 14:41
@bball07 bball07 changed the title Etsy guide [docs]: Guide on working with Etsy in Gatsby Feb 19, 2020
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started on this and then realized @AishaBlake should do this one. But figured I'd leave the start of what I did!

The overarching recommendation is that this reads more like a tutorial than a reference doc. Take a look at the reference doc guide for help with understanding the difference.

www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
@AishaBlake
Copy link

AishaBlake commented Feb 19, 2020

Sent this without a comment unintentionally. Roll with these suggestions for now and maybe Marcy can help if there's no option to open a test store without providing your bank info. We should make sure each section is as accurate as possible before merging!

Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a really great addition to the Gatsby docs! I left some comments about the content we need to see as part of this PR. Please let us know if you have any questions.

docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking better! I've left some comments to elicit more context, as this is one of the first docs of its kind so it presents an opportunity to really guide Gatsby users toward an e-commerce solution. We want to inspire them on what to do next if possible, even if the doc only shows a basic sourcing setup in detail.

docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
Copy link

@AishaBlake AishaBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these are additions or adjustments to things Marcy's already said. I think the only new thing that needs to be changed is the capitalization of "title" in the frontmatter!

docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
www/src/data/sidebars/doc-links.yaml Outdated Show resolved Hide resolved
docs/docs/working-with-Etsy-in-Gatsby.md Outdated Show resolved Hide resolved
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great Aisha! Left some comments/suggestions below.

In particular, I tried to soften the advantages section some. I think this still gets across the benefits of Gatsby in this situation, but let me know if you disagree.

docs/docs/sourcing-from-etsy.md Outdated Show resolved Hide resolved
docs/docs/sourcing-from-etsy.md Outdated Show resolved Hide resolved
docs/docs/sourcing-from-etsy.md Show resolved Hide resolved
docs/docs/sourcing-from-etsy.md Show resolved Hide resolved
docs/docs/sourcing-from-etsy.md Show resolved Hide resolved
docs/docs/sourcing-from-etsy.md Outdated Show resolved Hide resolved
docs/docs/sourcing-from-etsy.md Outdated Show resolved Hide resolved
@laurieontech
Copy link
Contributor

One last thing based on the alt text explanation. But other than that this is good to go!

@laurieontech
Copy link
Contributor

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants