fix(gatsby): fix codepaths that result in js errors #21829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When page-data.json results in a 500 or when we can't fetch a component we've hit some js errors instead of our own. So now we are actually throwing gatsby errors and error trackers make more sense.
Before:
TypeError: e.components[t] is not a function
and loaded the 404 page.TypeError: Cannot read property 'webpackCompilationHash' of undefined
and refresh the page.After:
Error: page resources for /stale/ not found. Not rendering React
and loaded the 404 page.Error: page resources for /new-beginnings/ not found. Not rendering React' of undefined
and refresh the page.Related Issues
#21429