Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(babel-preset-gatsby): Convert path-serializer to TS #22035

Conversation

MichaelDeBoey
Copy link
Contributor

Description

Convert path-serializer to TS

Related Issues

Related to #21995

@MichaelDeBoey MichaelDeBoey force-pushed the convert-babel-preset-gastby/path-serializer branch 2 times, most recently from bbddd23 to dfc14fa Compare March 7, 2020 22:19
@MichaelDeBoey MichaelDeBoey force-pushed the convert-babel-preset-gastby/path-serializer branch from dfc14fa to 97070d6 Compare March 7, 2020 22:35
blainekasten
blainekasten previously approved these changes Mar 8, 2020
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, but once you get the tests to pass I am happy to merge this!

@MichaelDeBoey
Copy link
Contributor Author

@blainekasten Can't figure out why the tests are failing tbh

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pieh pieh merged commit f0d02dc into gatsbyjs:master Mar 9, 2020
@MichaelDeBoey MichaelDeBoey deleted the convert-babel-preset-gastby/path-serializer branch March 9, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants