Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): migrate spinner to typescript #22080

Merged
merged 2 commits into from
Mar 9, 2020
Merged

chore(cli): migrate spinner to typescript #22080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42742a2
chore: migrate spinner to typescript
Naturalclar Mar 9, 2020
c5e1f73
Merge branch 'master' of https://github.com/gatsbyjs/gatsby into chor…
Naturalclar Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/gatsby-cli/src/reporter/loggers/ink/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ import { Box, Static } from "ink"
import isTTY from "../../../util/is-tty"
import { trackBuildError } from "gatsby-telemetry"

import Spinner from "../ink/components/spinner"
import { Spinner } from "../ink/components/spinner"
import { ProgressBar } from "../ink/components/progress-bar"

import { Message } from "../ink/components/messages"
import Error from "./components/error"
import Develop from "../ink/components/develop"
Expand Down
16 changes: 0 additions & 16 deletions packages/gatsby-cli/src/reporter/loggers/ink/components/spinner.js
View file
Open in desktop

This file was deleted.

20 changes: 20 additions & 0 deletions packages/gatsby-cli/src/reporter/loggers/ink/components/spinner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import React from "react"
blainekasten marked this conversation as resolved.
Show resolved Hide resolved
import { Box } from "ink"
import InkSpinner from "ink-spinner"

interface IProps {
text: string
statusText?: string
}
export function Spinner({ text, statusText }: IProps): JSX.Element {
blainekasten marked this conversation as resolved.
Show resolved Hide resolved
let label = text
if (statusText) {
label += ` — ${statusText}`
}
blainekasten marked this conversation as resolved.
Show resolved Hide resolved

return (
<Box>
<InkSpinner type="dots" /> {label}
</Box>
)
}