chore(gatsby): Convert get-static-dir to typescript #22083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blainekasten
reviewed
Mar 9, 2020
|
|
||
| /** | ||
| * copyStaticDirs | ||
| * -- | ||
| * Copy files from the static directory to the public directory | ||
| */ | ||
| exports.copyStaticDirs = () => { | ||
| export const copyStaticDirs = (): void | Promise<void> => { |
There was a problem hiding this comment.
can you look into what it would take to make this always return Promise and what impacts that would have on any consuming functions? I don't like the difference in return types here
There was a problem hiding this comment.
Instead of returning Promise.resolve, he can just return
There was a problem hiding this comment.
Thanks @MichaelDeBoey!
I return undefined instead of Promise.resolve to pass consistent-return rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert
utils/get-static-dirto typescriptRelated Issues
Related to #21995