Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Feedback/Env Var docs to follow style guide #22146

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

marcysutton
Copy link
Contributor

@marcysutton marcysutton commented Mar 10, 2020

Description

In looking at the new doc on CLI Feedback, I noticed it didn't follow the Gatsby Style Guide. I added a link to info about environment variables, and noticed that one had style guide issues as well. So this PR updates both of those docs to use the correct pronouns and improve some formatting.

Documentation

N/A

Related Issues

N/A

@marcysutton marcysutton requested a review from a team as a code owner March 10, 2020 17:31
@marcysutton marcysutton added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Mar 10, 2020
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Marcy! Found a couple small things on top of what you'd already reviewed.

docs/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/docs/environment-variables.md Outdated Show resolved Hide resolved
@marcysutton
Copy link
Contributor Author

Thanks @laurieontech, I've added your suggestions!

@laurieontech
Copy link
Contributor

Let's get this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants