Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby-cli): Convert util/configstore to typescript #22180

Merged
merged 3 commits into from
Mar 11, 2020
Merged

chore(gatsby-cli): Convert util/configstore to typescript #22180

merged 3 commits into from
Mar 11, 2020

Conversation

mottox2
Copy link
Contributor

@mottox2 mottox2 commented Mar 11, 2020

Description

Convert util/configstore to typescript

Related Issues

Related to #21995

@mottox2 mottox2 requested a review from a team as a code owner March 11, 2020 15:14
@mottox2
Copy link
Contributor Author

mottox2 commented Mar 11, 2020

@blainekasten
Thanks! I use gatsby-core-utils/get-config-store.
Should I rename this file to util/package-manager.ts?

blainekasten
blainekasten previously approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten
Copy link
Contributor

@mottox2 I like that idea of renaming it to package-manager if you could update all the references too. I'll wait for that then merge

blainekasten
blainekasten approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: TypeScript migration labels Mar 11, 2020
@gatsbybot gatsbybot merged commit d90dad0 into gatsbyjs:master Mar 11, 2020
@blainekasten blainekasten mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mottox2 @blainekasten @gatsbybot